fix: Add back v3/ext/id.go #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was removed between v3.0.0-testing.5 and v3.1.0. This can cause issues when modules depend on v3.0.0-testing.5. Running `go get -u github.com/me/my-module` will update the dependeny on log15 to the latest "minor" version which is v3.1.0. This version is missing the `v3/ext/id.go` file and causes programs not to be able to build when upgrading Signed-off-by: Jonathan Stacks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found this issue in ngrok/ngrok-go#213 (comment)
This file was removed between v3.0.0-testing.5 and v3.1.0. This can cause issues when modules depend on v3.0.0-testing.5. Running
go get -u github.com/me/my-modulewill update the dependency on log15 to the latest "minor" version which is v3.1.0. This version is missing thev3/ext/id.gofile and causes programs not to be able to build when upgrading.I believe releasing a v3.1.1 with this file being reinstated will help prevent this issue.
Reading https://go.dev/ref/mod#versions,
It seems like log15 removing this function is valid so this could just be an issue with the go tooling. I still think releasing a patch version that adds this back would help prevent paper cuts like this.