-
Notifications
You must be signed in to change notification settings - Fork 36
feat(passport): v3 #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(passport): v3 #2744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
View your CI Pipeline Execution ↗ for commit 583b130
☁️ Nx Cloud last updated this comment at |
| if (anonymousId) { | ||
| href += `&third_party_a_id=${anonymousId}`; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this to track users across the embedded login prompt & the Auth0 login flow, don't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests removed. Are they going to be rewritten?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added tests
Summary
next version of Immutable Passport SDK.
Tasks (all tasks below must keep Passport SDK and Passport sample app working)
Stage 1
Stage 2
Stage 3 - not this PR
Stage 4 - not this PR
new wallet and auth interface
For apps that only need wallet functionality:
For apps that need user profile access:
Note
Splits Passport into new
@imtbl/authand@imtbl/walletpackages, introducesconnectWalletAPI and refactors Passport/SDK and sample app to use them while removing environment-centric configs.@imtbl/authand@imtbl/wallet; Passport now composes these internally.connectWalletwith optional default Auth; supports multi-chainChainConfig, EIP-6963 announcement, session activity updates.GuardianClient,RelayerClientrefinements, overlay UI components, and wallet linking helpers (linkExternalWallet,getLinkedAddresses).@imtbl/auth/@imtbl/wallet, simplifies APIs, re-exports types/errors; IMX workflows moved toImxGuardianClient.@imtbl/authand@imtbl/wallet; updates exports and re-exports across packages.activeZkEvmProvider, connect with defaults), UI tweaks, and event wiring.uuid,@types/jest,tsup), bumps HuskyNODE_OPTIONS.Written by Cursor Bugbot for commit 583b130. This will update automatically on new commits. Configure here.