Skip to content

Conversation

@FlorianKirmaier
Copy link
Contributor

This PR introduces a developer mode for the app.
It makes it especially easy to open ScenicView with a shortcut, which greatly simplifies development.
Having all the dev-tools enabled by default can be a significant boost to developer productivity.

You can start the app with the following commands:

  • ./mvnw -f dev javafx:run
  • ./mvnw -f dev -Pjpro jpro:run

Future ideas:

  • Leak detection for popups using JMemoryBuddy
  • CSSFX only in dev mode

Possible issues:

JavaFX plugin:
I noticed that I cannot use "application" as a subproject as long as a jpackager goal is configured.
For this PR, I removed the goals. I am not sure if they are actually used, since there are other goals for creating the installer under the create-installer profile. This might block the PR for now.

ScenicView dependency:
I am using a slightly modified version of ScenicView, currently hosted in our Sandec repository.
If using this dependency causes problems, it could also block the PR.
If needed, the dependency can be published to Maven Central, which may take some time.

Bonus:
Removed the LoginFeatureFlag part, as it was overengineered without real benefit.

Added dev mode of the app, which automatically enables Scenic View.
Can be opened with ctrl+shift+s anywhere.
It also adds a generic mechanism, to add more developer tools.
Added dev mode of the app, which automatically enables Scenic View.
Can be opened with ctrl+shift+s anywhere.
It also adds a generic mechanism, to add more developer tools.
@carldea
Copy link
Contributor

carldea commented Sep 25, 2025

@FlorianKirmaier great work! I need to digest your suggestions a bit and share this with the architecture team.
They may have suggestions about the maven goals (can they be removed?). We might want to understand the github actions workflows that run jpackager (make sure profiles don't conflict).

Not sure why the build failed.

Small cleanups
@FlorianKirmaier
Copy link
Contributor Author

Hm, looks to my like something in the CI pipeline glitches, because i added the sandec repo for the ScenicView fork.

I'll try to report the bug with the subproject/jpackager/javafx-maven-plugin.

@FlorianKirmaier FlorianKirmaier marked this pull request as draft September 25, 2025 14:39
@FlorianKirmaier
Copy link
Contributor Author

I've created ticket for the problem with JLink: openjfx/javafx-maven-plugin#187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants