-
Notifications
You must be signed in to change notification settings - Fork 50
Water module units + size trimming #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Wegatriespython
merged 26 commits into
iiasa:main
from
Wegatriespython:water_module_latest
Jul 29, 2025
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
285cda7
Use registry to change units(MCM, GWa)
Wegatriespython 9803f35
Add get_vintage_and_active_year
Wegatriespython 9cb883d
Swap xslx to csv
Wegatriespython fa894a2
Disable cooling calibration constraints
Wegatriespython 9799958
Remove xslx files
Wegatriespython 1345c7b
Remove cool calib from water/build.py
Wegatriespython c35e223
Add new units + calib removal
Wegatriespython bf9d138
Remove hardcoded vtg yrs
Wegatriespython 7ecfd4f
Adjust infra df bound desal
Wegatriespython cc4b454
Add test get_vintage_and_active_years
Wegatriespython d96217f
Add extract_salinewater_cool
Wegatriespython ceb1893
Fix share_commodity_up
Wegatriespython a88e93d
Add tests for na and duplicates
Wegatriespython 7ad2fcf
Change Extract_salinewater to extract_salinewater_cool
Wegatriespython ac62e8a
Correct electr input to Gwa/km3 infrastructure
Wegatriespython 80b28b8
Deactivate share calib
Wegatriespython 747cff7
Standardize unit conv factors water data
Wegatriespython 4a5f53d
Replace map_yv_ya_lt with get_vintage_and_active_years
Wegatriespython e288fd7
Use scen.firstmodelyear infrastructure
Wegatriespython 3fe98c6
Add inp return infrastructure
Wegatriespython ccbb205
Verify GLOBIOM unit MCM input
Wegatriespython 4023bd2
Add basins_country_R12
Wegatriespython 975f5a2
Move pol_scen out of if cond
adrivinca a369fd3
Add type checking
Wegatriespython 56f9ba8
Rename variable in water_for_ppl
Wegatriespython d93345c
Update whatsnew for #371
Wegatriespython File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
792 changes: 792 additions & 0 deletions
792
message_ix_models/data/water/delineation/basins_country_R12.csv
Large diffs are not rendered by default.
Oops, something went wrong.
452 changes: 452 additions & 0 deletions
452
message_ix_models/data/water/infrastructure/all_basins.csv
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| tec,incmd,inlvl,outcmd,outlvl,recovery_rate_low,recovery_rate_mid,recovery_rate_high,cooling_water_withdrawal_low,cooling_water_withdrawal_mid,cooling_water_withdrawal_high,cooling_water_return_low,cooling_water_return_mid,cooling_water_return_high,electricity_input_low,electricity_input_mid,electricity_input_high,heat_input_low,heat_input_mid,heat_input_high,thermal_pollution_low,thermal_pollution_mid,thermal_pollution_high,inv_cost_low,inv_cost_mid,inv_cost_high,fix_cost_low,fix_cost_mid,fix_cost_high,var_cost_low,var_cost_mid,var_cost_high,capacity_factor_low,capacity_factor_mid,capacity_factor_high,lifetime_low,lifetime_mid,lifetime_high | ||
| membrane,salinewater_basin,water_avail_basin,freshwater_basin,water_supply_basin,0.4,0.35,0.3,2.4,5.2,7.1,2.3,5.1,7,0.171,0.342,0.456,0.456,1.026,1.368,0.04275,0.0855,0.114,4383.561644,5205.479452,6027.39726,369.8630137,424.6575342,369.8630137,0,0,0,0.9,0.85,0.8,50,30,25 | ||
| distillation,salinewater_basin,water_avail_basin,freshwater_basin,water_supply_basin,0.45,0.4,0.35,0,0,0,0,0,0,0.342,0.456,0.571,0,0,0,0,0,0,3561.643836,4246.575342,4931.506849,3561.643836,4520.547945,4931.506849,0,0,0,0.9,0.85,0.8,50,30,25 |
3 changes: 0 additions & 3 deletions
3
message_ix_models/data/water/infrastructure/desalination.xlsx
This file was deleted.
Oops, something went wrong.
29 changes: 29 additions & 0 deletions
29
message_ix_models/data/water/infrastructure/extraction_techs.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| tec,incmd,inlvl,outcmd,outlvl,value_low,value_mid,value_high,capacity_factor_low,capacity_factor_mid,capacity_factor,investment_low_high,Likely Units,investment_mid,investment_high,technical_lifetime_low,technical_lifetime_mid,technical_lifetime_high,fix_cost_low,Likely Units.1,fix_cost_mid,fix_cost_high,var_cost_low,var_cost_mid,var_cost_high,out_value_low,out_value_mid,out_value_high,recovery_rate_low,recovery_rate_mid,recovery_rate_high | ||
| extract_groundwater,,,,,,,,,,,,,,,15.0,20.0,25.0,,,,,,,,,,,,, | ||
| extract_surfacewater,,,,,,,,,,,,,,,40.0,50.0,60.0,,,,,,,,,,,,, | ||
| rural_discharge,rural_collected_wst,water_treat,,,1.0,1.0,1.0,1.0,1.0,1.0,660.0,USD/(m³/day),2080.0,3560.0,30.0,25.0,20.0,66.0,USD/(m³/day)/yr,208.0,356.0,0.0,0.0,0.0,0.97,0.95,0.9,0.0,0.0,0.0 | ||
| rural_discharge,electr,final,,,0.0,0.01484018,0.02968037,,,,,,,,,,,,,,,,,,,,,,, | ||
| rural_recycle,rural_collected_wst,water_treat,freshwater_basin,water_supply_basin,1.0,1.0,1.0,0.95,0.9,0.85,495.0,USD/(m³/day),1560.0,2670.0,40.0,30.0,25.0,49.5,USD/(m³/day)/yr,156.0,267.0,0.0,0.0,0.0,0.9,0.8,0.7,0.0,0.0,0.0 | ||
| rural_sewerage,electr,final,,,0.00197869,0.04303653,0.08409437,,,,,,,,,,,,,,,,,,,,,0.0,0.0,0.0 | ||
| rural_sewerage,rural_collected_wst,final,rural_collected_wst,water_treat,1.0,1.0,1.0,1.0,1.0,1.0,870.2054794520549,USD/(m³/day),1613.8356164383563,2278.3561643835615,50.0,40.0,30.0,217.55136986301372,USD/(m³/day)/yr,403.45890410958907,569.5890410958904,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| rural_t_d,freshwater_basin,water_supply_basin,rural_mw,final,1.0,1.0,1.0,1.0,1.0,1.0,666.027397260274,USD/(m³/day),901.095890410959,2154.7945205479455,30.0,20.0,10.0,33.301369863013704,USD/(m³/day)/yr,45.05479452054795,107.73972602739728,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| rural_t_d,electr,final,,,0.00228311,0.19178082,0.38127854,,,,,,,,,,,,,,,,,,,,,,, | ||
| rural_unconnected,freshwater_basin,water_supply_basin,rural_disconnected,final,1.0,1.0,1.0,1.0,1.0,1.0,0.0,,0.0,0.0,1.0,1.0,1.0,0.0,,0.0,0.0,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| rural_untreated,rural_uncollected_wst,final,,,1.0,1.0,1.0,1.0,1.0,1.0,0.0,,0.0,0.0,1.0,1.0,1.0,0.0,,0.0,0.0,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| urban_discharge,urban_collected_wst,water_treat,,,1.0,1.0,1.0,0.95,0.9,0.85,303.0,USD/(m³/day),429.0,627.0,40.0,30.0,25.0,21.0,USD/(m³/day)/yr,35.0,67.0,0.0,0.0,0.0,0.95,0.9,0.85,0.0,0.0,0.0 | ||
| urban_discharge,electr,final,,,0.0,0.01484018,0.02968037,,,,,,,,,,,,,,,,,,,,,,, | ||
| urban_recycle,urban_collected_wst,water_treat,freshwater_basin,water_supply_basin,1.0,1.0,1.0,0.95,0.9,0.85,2761.643835616438,USD/(m³/day),3704.1095890410957,5506.849315068493,40.0,30.0,25.0,172.60273972602738,USD/(m³/day)/yr,268.4931506849315,479.4520547945205,0.0,0.0,0.0,0.9,0.8,0.7,0.0,0.0,0.0 | ||
| urban_recycle,electr,final,,,0.091324200913242,0.1141552511415525,0.17123287671232876,,,,,,,,,,,,,,,,,,,,,0.0,0.0,0.0 | ||
| urban_sewerage,urban_collected_wst,final,urban_collected_wst,water_treat,1.0,1.0,1.0,1.0,1.0,1.0,1160.2739726027398,USD/(m³/day),2151.780821917808,3037.808219178082,50.0,40.0,30.0,290.06849315068496,USD/(m³/day)/yr,537.945205479452,759.4520547945204,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| urban_sewerage,electr,final,,,0.00197869,0.04303653,0.08409437,,,,,,,,,,,,,,,,,,,,,0.0,0.0,0.0 | ||
| urban_t_d,freshwater_basin,water_supply_basin,urban_mw,final,1.0,1.0,1.0,1.0,1.0,1.0,1491.7808219178085,USD/(m³/day),2766.5753424657537,3905.7534246575347,50.0,40.0,30.0,372.9452054794521,USD/(m³/day)/yr,691.6438356164384,976.4383561643837,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| urban_t_d,electr,final,,,0.00228311,0.19178082,0.38127854,,,,,,,,,,,,,,,,,,,,,,, | ||
| urban_unconnected,freshwater_basin,water_supply_basin,urban_disconnected,final,1.0,1.0,1.0,1.0,1.0,1.0,0.0,,0.0,0.0,1.0,1.0,1.0,0.0,,0.0,0.0,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| urban_untreated,urban_uncollected_wst,final,,,1.0,1.0,1.0,1.0,1.0,1.0,0.0,,0.0,0.0,1.0,11.0,1.0,0.0,,0.0,0.0,0.0,0.0,0.0,1.0,1.0,1.0,0.0,0.0,0.0 | ||
| ,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| ,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| ,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| ,Notes ,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| ,"rural sewerage, recyling, treatment make sense only for a handful of basins in the global north. ",,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| ,urban technologies need to be geo-matched against urban basins,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| ,"cost estimates need units, confirmation on whether they are const USD or nominal. ",,,,,,,,,,,,,,,,,,,,,,,,,,,,, |
3 changes: 0 additions & 3 deletions
3
message_ix_models/data/water/infrastructure/extraction_techs.xlsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wegatriespython @glatterf42 while reviewing #388 I noticed that this heading and the bullet list below have a leading indent of two spaces. In the built HTML docs, the heading does not appear and the list items don't match the rest of the list.
I'll correct the change in a commit on that branch, to align with the style used for previous releases.
In the future, please closely eyeball docs additions to make sure they render as you intend. The rest of the same file can be an example for formatting.