-
Notifications
You must be signed in to change notification settings - Fork 50
Test genno vs. legacy reporting #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=======================================
- Coverage 75.3% 74.7% -0.7%
=======================================
Files 274 274
Lines 22492 22545 +53
=======================================
- Hits 16958 16856 -102
- Misses 5534 5689 +155
🚀 New features to boost your workflow:
|
9f91bdd to
7bc4db1
Compare
1034331 to
a74d8fd
Compare
a74d8fd to
bad33bc
Compare
bad33bc to
127bf7c
Compare
Import in modules to avoid warnings.
127bf7c to
f943878
Compare
|
Hi @macflo8 @Wegatriespython @macflo8 @junukitashepard —as mentioned yesterday, I've brought this PR up to date and got it ready to merge. I've requested a review mainly "FYI". Later, as the scope of IAMC output from the genno reporting grows, I will show how to adjust the @yiyi1991 FYI those variables function as the checklist you mentioned in Slack. Only one ✅ is needed to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Looks ready be merged!
This PR adds:
.test_report.test_compare(), and associated utility function that:This functions as a test of known differences between the output of the legacy and genno-based reporting for this particular scenario. The added variables NOT_IMPLEMENTED_MEASURE and NOT_IMPLEMENTED_IAMC can be modified and reduced as the genno-based reporting is expanded towards feature parity with the legacy reporting.
Also:
default_units.yamlto suppress some of the many warnings about missing "conversion factors"..report.Config.modulesand.iter_callbacks().How to review
PR checklist