Upgrade to ZED SDK 5.x #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvertdw
approved these changes
Jun 21, 2025
PotatoPeeler3000
approved these changes
Jun 25, 2025
calvertdw
reviewed
Aug 27, 2025
| ZEDSVOLogger zedSVOLogger = new ZEDSVOLogger(); | ||
|
|
||
| zedSVOLogger.start(svoFile, datFile, | ||
| zedSVOLogger.connect(svoFile, datFile, |
calvertdw
approved these changes
Aug 28, 2025
TomaszTB
approved these changes
Aug 29, 2025
| // on the robot at the moment both the sensor & controller are running | ||
| long sensorTimestamp = sl_get_current_timestamp(cameraID); | ||
| long controllerTimestamp = sensorTimestamp - controllerZeroInSensorFrame; | ||
| timestampWriter.write("%d %d %s%n".formatted(controllerTimestamp, sensorTimestamp, svoPrefix)); |
There was a problem hiding this comment.
Just pointing out that the timestampWriter could be null if an exception was thrown in the connect method, and that's not handled here. Unlikely to happen, but worth noting
| try | ||
| { | ||
| // We assume both the sensor on board & controller real time thread clocks | ||
| // run at the same speed to try an resolve delay and time stretching issues. |
There was a problem hiding this comment.
Suggested change
| // run at the same speed to try an resolve delay and time stretching issues. | |
| // run at the same speed to try and resolve delay and time stretching issues. |
Comment on lines
+127
to
+128
| // Wait some time before trying to grab again | ||
| ThreadTools.park(5.0); |
There was a problem hiding this comment.
Do we know how this affects the resulting SVO file? I'd imagine it'd be stuck on the previous frame for some time, but maybe it doesn't handle it well?
There was a problem hiding this comment.
Yeah might come back to this, I think for now its fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.