[FIX] update the guidelines for enumeration switch cases

[mitulmanish]

• Adds new guidelines for enumeration switch cases

[martinpilch]

Makes sense to me. It makes code safer 👍

[pablocaif]

Not 100% agreed for this to be a guideline. I think it depends on the enum specially if the other options are completely irrelevant to what the switch is trying to address. Another example would be you have an error enum with multiple errors that and you can only act on a handful it becomes boilerplate to enumerate all of them just to follow a rule. For example something that I'm working for a personal project can throw this error https://developer.apple.com/documentation/networkextension/nehotspotconfigurationerror
Of course there are different opinions and as usual there is a balance to achieve as well as preferences are involved so if the rest of the team is ok with this I'll adhere.
Cases like

enum LoginResult {
 case loading
 case success
 case error
}

Make complete sense to have no default statement

[pablocaif]

Our own NetworkServiceError is another example.

[mokagio]

Perhaps this recommendation could be relaxed a bit?

There is a lot of value in not using the default case, but there are as @pablocaif suggests, instances in which it would be too cumbersome to do.

[pablocaif]

👍

[mokagio]

This sentence needs a . at the end 😉 .

Also, what is the rationale for this recommendation? It should be added as well.

[mokagio]

Great initiative, thanks! A few comments.