Skip to content

Conversation

evyncke
Copy link
Collaborator

@evyncke evyncke commented Jul 19, 2025

Addressing #9021 by making statement-* docs 'diffable'

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.73%. Comparing base (e16d568) to head (4ef7b5f).
⚠️ Report is 114 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9180   +/-   ##
=======================================
  Coverage   88.72%   88.73%           
=======================================
  Files         321      321           
  Lines       41851    41860    +9     
=======================================
+ Hits        37134    37144   +10     
+ Misses       4717     4716    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks rjsparks marked this pull request as draft July 19, 2025 13:23
@rjsparks
Copy link
Member

There will have to be explicit support added to author-tools before we can merge this.
@kesara - could you look at whether it would be reasonable to handle requests like:

https://author-tools.ietf.org/iddiff?url1=statement-iesg-ballot-procedures-for-documents-00&url2=statement-iesg-ballot-procedures-for-documents-01&difftype=--html

@kesara
Copy link
Member

kesara commented Jul 19, 2025

There will have to be explicit support added to author-tools before we can merge this. @kesara - could you look at whether it would be reasonable to handle requests like:

https://author-tools.ietf.org/iddiff?url1=statement-iesg-ballot-procedures-for-documents-00&url2=statement-iesg-ballot-procedures-for-documents-01&difftype=--html

At the moment author tools doesn't know about statements.
How do you get a text or markdown of a statement from DT?
For example, I don't see a way to get text statement for https://datatracker.ietf.org/doc/statement-iesg-ballot-procedures-for-documents/01/

@evyncke
Copy link
Collaborator Author

evyncke commented Jul 19, 2025

So, it seems that a .TXT should be generated when a new .MD statement is issued ?

OTOH, comparing the .MD would probably be "good enough"

@rjsparks
Copy link
Member

md should be compared to md when it exists.

@kesara
Copy link
Member

kesara commented Jul 19, 2025

@rjsparks, But does DT expose md or txt files for statements?

@evyncke
Copy link
Collaborator Author

evyncke commented Aug 11, 2025

Any news about DT exposing somewhere the .MD for the statements ? Else, I could try to code one.

@rjsparks
Copy link
Member

(this may be a duplicate):
There is no simple endpoint for fetching the raw markdown of a statement.
There is an ongoing conversation at #6599 on how to do this generally, and statements should follow the outcome of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants