Skip to content

Convergence on objective for NSGAII #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 247 commits into
base: devel
Choose a base branch
from
Open

Convergence on objective for NSGAII #2446

wants to merge 247 commits into from

Conversation

@joshua-cogliati-inl
Copy link
Contributor

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?

Just to run regression tests on a NSGAII branch fix.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

JunyungKim and others added 30 commits February 19, 2023 12:48
NSGA-II implementation with properly printing optimal solutions at th…
061058e 
…e iteration is completed.
Unnecessary changes in DataSet.py have been removed.
ab4315c
Unnecessary changes in DataSet.py have been removed.
8b7f5d3
ZDT test is added.
3fcde82
Optimizer.py and RavenSampled.py are updated after having regression …
15debe4 
…tests. Most of conflicts are resolved.
minor update on Optimizer.py
64510df
@Jimmy-INL
temporary fix, not the way I want
b1f0c3f
NSGA-II testing fiels (multiSum wConstratint and ZDT1) are added.
52389c3
@Jimmy-INL
moving models, xmls, and trying to resolve GD after converting object…
391b9c3 
…ive to a list
@Jimmy-INL
fixing simulated annealing to accept a list of objectives
da9e0dd
@Jimmy-INL
fixing rook to compare infs
1fd2175
@Jimmy-INL
Merge branch 'junyung-Mohammad-NSGAII' into JunyungKim-junyung-Mohamm…
7cedf83 
…ad-NSGAII
@Jimmy-INL
making one mod in RAVENSAmpled
305c2ac
@Jimmy-INL
making self._minMax a list
c820eea
@Jimmy-INL
erroring out if type is not in ['min', 'max']
21bf42d
@Jimmy-INL
updating HERON to b316024
e639803
@Jimmy-INL
Merge branch 'devel' into enablingMinMaxList
12e11f0
@Jimmy-INL
updating dependencies
be64a4d
@Jimmy-INL
Merge branch 'enablingMinMaxList' of github.com:Jimmy-INL/raven into …
ccde4d9 
…enablingMinMaxList
@Jimmy-INL
removing a trailing space
95682a1
@Jimmy-INL
removing windows line endings
c3688e2
@Jimmy-INL
change to unix ending
e25cc37
@Jimmy-INL
adding the zdt_model.py
f0d1412
@Jimmy-INL
converting zdt to unix line endings
c2ca46e
@Jimmy-INL
Juan's change to simulateData for the interface
1f1b969
@Jimmy-INL
resolving diff based on different batch Size, thanks @wangcj05
c7aebf3
@Jimmy-INL
converting SimukateData.py to unix line endings
64e97a9
@Jimmy-INL
regolding to print all batches in MOO
b29661b
@Jimmy-INL
slight mods
9626956
@Jimmy-INL
regolding and reverting inf in fitness
34d5cb2
joshua-cogliati-inl and others added 27 commits February 6, 2025 15:37
@joshua-cogliati-inl
Moving computing offSpringFitness outside of constraintHandling.
e56e193
@joshua-cogliati-inl
Switching to using _isMultiObjective.
d417b94
@joshua-cogliati-inl
Fixes problem when len(y) == 2
3b4ca3f 
If the yerr was a 2 dimentional array with outer dimension 2, it would
go to the first if statement instead of the len(yerr) elif.
This resulted in an error ValueError: 'y1' is not 1-dimensional.
@joshua-cogliati-inl
Moving some functionality from survivorSelection to GeneticAlgorithm.
94b7bfd
@joshua-cogliati-inl
Adding to Authors.
ec08f5c
@joshua-cogliati-inl
Fixing codereview survivorSelectors requests.
4e24950
@joshua-cogliati-inl
Updating docstring.
3ec8757
@joshua-cogliati-inl
Combining _resolveNewGeneration and _resolveNewGenerationMulti into one.
d5e7b25
@joshua-cogliati-inl
Simplifying _checkConvObjective.
6a77bcc
@joshua-cogliati-inl
Changes from code review.
7a1a0b8
@joshua-cogliati-inl
Updating docstrings.
4ba829d
@joshua-cogliati-inl
Simplifying if.
9d241d0
@joshua-cogliati-inl
More simplification.
41a41b2
@joshua-cogliati-inl
Combining common code in if statements.
1b38c95
@joshua-cogliati-inl
Code review cleanup.
03bc890
@joshua-cogliati-inl
Readding locationsGenorator function.
a25fcdf
@joshua-cogliati-inl
Adding dtype.
eb11be9
@joshua-cogliati-inl
Adding docstrings.
a854133
@joshua-cogliati-inl
Switch to self._isMultiObjective as suggested by Mohammad.
470e09f
@joshua-cogliati-inl
Skipping converting to list.
b83b29d
@joshua-cogliati-inl
Adding comments.
7f27ac8
@Jimmy-INL
modifying comments and convering to is None instead of == None
9eb5b35
@Jimmy-INL
adding descriptions to three tests and removing some unnecessasry com…
8943fef 
…ments
@Jimmy-INL
Starting the fix for objective convergence
1b1d6e7
@joshua-cogliati-inl
Look in gene pool for convergence value.
7117879
@joshua-cogliati-inl
Modify test to check objective convergence.
09d9718
@joshua-cogliati-inl
Adding test to check single variable objective convergence.
94d8992
@joshua-cogliati-inl joshua-cogliati-inl changed the title Convergence on object for NSGAII Convergence on objective for NSGAII Feb 25, 2025
@moosebuild
Copy link

Job Test slurm bitterroot on 94d8992 : invalidated by @joshua-cogliati-inl

failed in build_raven remove directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Do Not Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@joshua-cogliati-inl @moosebuild @Jimmy-INL @JunyungKim @alfoa @PaulTalbot-INL @GabrielSoto-INL @wanghy-anl @caleb-sitton-inl @wangcj05