Skip to content

WIP preincrement improvements #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP preincrement improvements #3472

wants to merge 1 commit into from

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented May 6, 2025

Problem

#3468

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
    • I tried to copy and adapt the code used for post-increment, but I have doubts that this is the right approach.
  • Which part of this PR is most in need of attention/improvement?
    • Everything :)
  • At least one test covering the code changed

@ds5678 ds5678 marked this pull request as draft May 6, 2025 05:19
@ds5678 ds5678 mentioned this pull request May 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ds5678