Skip to content

Handle explicit optional parameter after default parameter #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented May 5, 2025

Resolves #3469

Solution

  • Any comments on the approach taken, its consistency with surrounding code, etc.
    • I implemented this in an extensions class, which is a little bit removed from the code that uses it.
  • Which part of this PR is most in need of attention/improvement?
    • Do you think my extension method needs more documentation?
    • Should there be any additional tests involving decimal constants?
  • At least one test covering the code changed

@ds5678 ds5678 force-pushed the improve-optional-argument-handling branch from a03cadb to c85b53d Compare May 7, 2025 23:42
@ds5678
Copy link
Contributor Author

ds5678 commented May 17, 2025

Is there anything else that needs done for this pull request?

@siegfriedpammer siegfriedpammer merged commit c1ecf1a into icsharpcode:master May 17, 2025
5 checks passed
@siegfriedpammer
Copy link
Member

Sorry for the wait... I had second thoughts about the use of an extension method (and then other things came up) instead of implementing this directly in the type system, but it's fine, because this way it's independent from the actual implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional parameters with implicit default values
2 participants