Changed to allow only certain TLD zone files to be downloaded, instead of all #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fepimentel
approved these changes
Apr 27, 2023
|
I appreciate this is old, but is anyone able to merge these changes in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the code to enable the user to download only a subset of zone files available to them. Despite the rest of the configuration being performed through the
config.jsonfile, this pull requests enables the zones to download as command line arguments, this is different, but for my purpose easier. I will need to download various zone files at different times and it is much easier from this perspective to be able to specify the zones to be downloaded as a command line argument as this is much easier than having to change the config file.