default cert: changing the certificate default location #10
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
raviteja-b
reviewed
Nov 12, 2025
conf/provisioning.conf
Outdated
| { | ||
| "port":8090, | ||
| "cert_root":"/tmp/", | ||
| "cert_root":"/", |
Contributor
There was a problem hiding this comment.
I think this cert_root can be completely removed
subdir/attestationd/conf/spdm.conf
Outdated
| "port": "8080", | ||
| "self-signed": true, | ||
| "exchange_prefix": "/tmp/", | ||
| "exchange_prefix": "/", |
Contributor
There was a problem hiding this comment.
this property also can be removed.
raviteja-b
approved these changes
Nov 12, 2025
The default location for certificate changed form tmp to /etc folder signoff-by: Abhilash Raju <[email protected]>
abhilashraju
force-pushed
the
changing_default_cert_dir
branch
from
359d634 to
fc765ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default location for certificate changed form tmp to /etc folder
signoff-by: Abhilash Raju [email protected]