Skip to content

Fix 726312: Fix for pel registry missing #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1120
Choose a base branch
from
Open

Fix 726312: Fix for pel registry missing #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions acfshell/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,24 +42,31 @@ flowchart TD
subgraph acfshell["acfshell"]
direction TB
M["Shell object"]
subgraph async["Async Script Execution"]
direction TB
N["Script Object"]
O["Script Runner"]
P["Timer Task"]
Q["Finished Script"]
R{"Dump Needed"}
S["Clear Results"]
T["Execute Dump"]
end
end
subgraph dumpmanager["dumpmanager"]
direction TB
A1["Dbug Collector"]
A2["PLDM"]
A3["PHYP"]

end
A["Redfish Client"] -- Installs ACF file --> B["bmcweb"]
B -- Invokes --> C
C --> D
D -- Validation Failed --> E
D -- Validation Success --> F
F --> G
G -- Resource Dump --> H
H -- Dump Dbus --> A1
A1 -- PLDM Dbus --> A2
A2 -- FileIO--> A3
G -- bmcshell --> I
G -- Service --> J
G -- Admin Reset --> K
Expand Down
11 changes: 4 additions & 7 deletions acfshell/script_runner.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,7 @@ struct ScriptRunner
{
try
{
co_await createInfoLog(
std::format("Start executing script: {} with dump needed {}",
filename, dumpNeeded));
co_await createInfoLog("xyz.openbmc_project.acfshell.ShellStarted");

bp::async_pipe ap(io_context);
bp::async_pipe ep(io_context);
Expand Down Expand Up @@ -300,13 +298,12 @@ struct ScriptRunner
c.exit_code())
<< std::endl;
co_await createInfoLog(
std::format("Script execution cancelled"
" for script: {}, exited with code {}",
hash, c.exit_code()));
"xyz.openbmc_project.acfshell.ShellCancelled");
}
else
{
co_await createInfoLog("Script execution Finished");
co_await createInfoLog(
"xyz.openbmc_project.acfshell.Completed");
}
ofs.close();
if (dumpNeeded)
Expand Down