[patch] Require RSL secret name as API parameter #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidd101010
requested review from
durera,
JonahLuckett,
andrercm,
sanjayprab,
terenceq,
whitfiea,
alequint and
leo-miran
as code owners
boonware
reviewed
May 13, 2025
| {% endfor %} | ||
| {% endif %} | ||
| data: | ||
| RSL_TOKEN: "{{ rslcfg.registration_key | b64encode }}" |
There was a problem hiding this comment.
registration_key is not the correct name of the variable
boonware
reviewed
May 13, 2025
|
|
||
| rsl: | ||
| url: "{{ rslcfg.url }}" | ||
| token : "{{ rslcfg.rsl_token }}" |
There was a problem hiding this comment.
The token should not be included here as it is a secret value. There should be a field called secretName whose value is {{ mas_aibroker_rsl_token_secret }}.
There was a problem hiding this comment.
The field names also need to match those in https://github.ibm.com/maximoappsuite/ibm-mas-aibroker/pull/156
boonware
reviewed
May 13, 2025
| debug: | ||
| msg: | ||
| - "rsl url ................. {{ rslcfg.url }}" | ||
| - "rsl token ............. {{ rslcfg.rsl_token }}" |
There was a problem hiding this comment.
Do not print the secret token value.
boonware
reviewed
May 13, 2025
| @@ -0,0 +1,36 @@ | |||
| - name: Read rsl config from environment | |||
There was a problem hiding this comment.
For consistency I would write "rsl" in capital letters here in the human-readable message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.