-
Notifications
You must be signed in to change notification settings - Fork 98
[patch] added support for MariaDB and Minio - both dependencies are mandatory for AIBrooker FVT integration #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
commit 5eb2cd4 Author: Sanjay Prabhakar <[email protected]> Date: Tue Nov 19 14:42:36 2024 +0000 [patch] fix restore for core and fix tar command in restore tasks (#1564) Co-authored-by: Sanjay Prabhakar <[email protected]>
commit 9206656 Author: David Parker <[email protected]> Date: Tue Dec 3 14:36:31 2024 +0000 [major] Use new OLM functions in mas-devops (#1573) commit 3ccdbef Author: Harsh Tamakuwala <[email protected]> Date: Mon Dec 2 18:30:04 2024 +0530 [patch] Fixes ibmcloud_api_key issue in COS deprovision for ibmcloud (#1581) Co-authored-by: Harsh Tamakuwala <[email protected]> commit 1283c03 Author: Terence Quinn <[email protected]> Date: Fri Nov 29 03:52:51 2024 -0600 [patch] create unique certificate for each db2 instance (#1579) commit e04138a Author: David Parker <[email protected]> Date: Tue Nov 26 21:40:39 2024 +0000 [patch] get_default_storage_classes should always set failed=False (#1578) commit 7014f49 Author: Sanjay Prabhakar <[email protected]> Date: Tue Nov 26 16:32:42 2024 +0000 [patch] Add estimates for cpd in readme (#1577) commit 9933bc2 Author: David Parker <[email protected]> Date: Tue Nov 26 13:46:05 2024 +0000 [patch] Use correct variable for mongo extras (#1576) commit bb720a3 Author: David Parker <[email protected]> Date: Tue Nov 26 13:32:30 2024 +0000 [patch] Set cpd_product_version from catalog metadata (#1575) commit ba23e83 Author: Terence Quinn <[email protected]> Date: Mon Nov 25 15:03:03 2024 -0600 [patch] Fix missing catalog_digest (#1574) Co-authored-by: David Parker <[email protected]> commit 0f60c61 Author: Sanjay Prabhakar <[email protected]> Date: Fri Nov 22 17:33:20 2024 +0000 [patch] Add back restore.yml.j2 (#1572) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 739c4d0 Author: David Parker <[email protected]> Date: Fri Nov 22 16:02:24 2024 +0000 [major] Overhaul backup/restore capability (#1557) Co-authored-by: Sanjay Prabhakar <[email protected]> commit d5ef410 Author: David Parker <[email protected]> Date: Fri Nov 22 12:39:48 2024 +0000 [doc] Fix formatting commit 61272c9 Author: Sanjay Prabhakar <[email protected]> Date: Fri Nov 22 12:27:00 2024 +0000 [patch] fix restore for manage role (#1571) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 0a13abd Author: Sanjay Prabhakar <[email protected]> Date: Thu Nov 21 10:40:05 2024 +0000 [patch] Db2 backup/restore: fix copy local to pod script (#1569) Co-authored-by: Sanjay Prabhakar <[email protected]> commit f474509 Author: David Parker <[email protected]> Date: Wed Nov 20 23:43:25 2024 +0000 [major] Move catalog & storage class metadata to python package (#1561) commit df4fe4c Author: Lokesh <[email protected]> Date: Wed Nov 20 08:49:28 2024 -0500 [patch] remove MIRRORLOGPATH folder creation (#1568) commit 5668f33 Author: Lokesh <[email protected]> Date: Wed Nov 20 07:49:43 2024 -0500 [patch] fix conflicting DB config (#1567) commit 5c595c1 Author: Sanjay Prabhakar <[email protected]> Date: Tue Nov 19 17:45:03 2024 +0000 [patch] can skip db2 in br_manage playbook (#1566) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 8c8f993 Author: stonepd <[email protected]> Date: Tue Nov 19 16:39:18 2024 +0000 [patch] update CP4D README, remove outdated fix code (#1565) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 5eb2cd4 Author: Sanjay Prabhakar <[email protected]> Date: Tue Nov 19 14:42:36 2024 +0000 [patch] fix restore for core and fix tar command in restore tasks (#1564) Co-authored-by: Sanjay Prabhakar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build fails plus please resolve the conflicts, there are many changes here to files I wouldn't expect to be being changed.
commit 9c33df9 Author: rene-oromtz <[email protected]> Date: Mon Jan 13 10:26:02 2025 -0600 [patch] Add missing api_version to k8s_info lookup (#1616) commit 0417879 Author: Harsh Tamakuwala <[email protected]> Date: Mon Jan 13 21:52:43 2025 +0530 [patch] Adds some deletion waits in suite_app_uninstall (#1615) Co-authored-by: Harsh Tamakuwala <[email protected]> commit 9a0893d Author: David Parker <[email protected]> Date: Mon Jan 13 16:05:34 2025 +0000 [patch] Run prettier on yaml files (#1621) commit d500473 Author: Tremaine Hart <[email protected]> Date: Fri Jan 10 15:32:13 2025 -0600 [patch] [MASCORE-5063] Problems with Restoring PV data - DT420492 (#1618) commit 0fa5980 Author: Anil Prajapati <[email protected]> Date: Thu Jan 9 02:28:38 2025 +0530 [minor] Support January Catalog Update (#1595) Co-authored-by: Parveen Kumar <[email protected]> commit 5653ebd Author: Harsh Tamakuwala <[email protected]> Date: Mon Jan 6 16:24:12 2025 +0530 [patch] Fixes manage namespace uninstall stuck in terminating state (#1611) Co-authored-by: Harsh Tamakuwala <[email protected]> commit 83d8365 Author: leo-miran <[email protected]> Date: Thu Dec 19 17:09:45 2024 -0300 [patch] Remove OCP 4.12 & 4.13 from rotation (#1609) commit 13770e9 Author: sekharcvalluri <[email protected]> Date: Thu Dec 19 19:19:48 2024 +0530 [patch] Fix cos_bucket picking incorrect resourcegroup (#1593) Co-authored-by: Harsh Tamakuwala <[email protected]> Co-authored-by: leo-miran <[email protected]> commit 0a3b97b Author: David Parker <[email protected]> Date: Thu Dec 19 13:47:57 2024 +0000 [major] Replace ICSP with IDMS (#1594) commit b08cda4 Author: Harsh Tamakuwala <[email protected]> Date: Thu Dec 19 18:49:47 2024 +0530 [patch] Update supported kafka versions (#1608) Co-authored-by: Harsh Tamakuwala <[email protected]> commit cf05717 Author: David Parker <[email protected]> Date: Thu Dec 19 11:39:55 2024 +0000 [patch] Lock mas-devops less than v2 (#1607) commit 6ff397e Author: David Parker <[email protected]> Date: Tue Dec 17 22:35:41 2024 +0000 [patch] Enable HMAC by default for IBM COS (#1606) commit 49b2099 Author: Rawa <[email protected]> Date: Thu Dec 12 16:28:49 2024 +0000 [patch] Fix subscription lookup in upgrade (#1589) Co-authored-by: Rawa Resul <[email protected]> commit 79c5991 Author: leo-miran <[email protected]> Date: Thu Dec 12 13:26:06 2024 -0300 [patch] fix default booleans for suite_dns (#1590) commit 1e91ba5 Author: Andrew Whitfield <[email protected]> Date: Thu Dec 12 07:34:31 2024 +0000 [patch] Increase rosa deprovision wait time (#1592) commit 91bd67b Author: Ian Boden <[email protected]> Date: Mon Dec 9 10:32:54 2024 +0000 [patch] reinstate zenmetastore and couchdb workarounds for cpd 4.8 (#1580) commit aa05d8a Author: Rawa <[email protected]> Date: Fri Dec 6 16:32:24 2024 +0000 [patch] Fix label_selectors pattern (#1586) Co-authored-by: Rawa Resul <[email protected]> commit e0ba0de Author: Parveen Kumar <[email protected]> Date: Fri Dec 6 19:23:46 2024 +0530 [minor] Support December catalog (#1562) Co-authored-by: Anil Prajapati <[email protected]> Co-authored-by: Jon Levell <[email protected]> Co-authored-by: Jon Levell <[email protected]> Co-authored-by: Ian Boden <[email protected]> Co-authored-by: Ian Boden <[email protected]> Co-authored-by: Anil Prajapati <[email protected]> Co-authored-by: Terence Quinn <[email protected]> Co-authored-by: David Parker <[email protected]> Co-authored-by: Rawa Resul <[email protected]> Co-authored-by: Rawa <[email protected]> commit 9206656 Author: David Parker <[email protected]> Date: Tue Dec 3 14:36:31 2024 +0000 [major] Use new OLM functions in mas-devops (#1573) commit 3ccdbef Author: Harsh Tamakuwala <[email protected]> Date: Mon Dec 2 18:30:04 2024 +0530 [patch] Fixes ibmcloud_api_key issue in COS deprovision for ibmcloud (#1581) Co-authored-by: Harsh Tamakuwala <[email protected]> commit 1283c03 Author: Terence Quinn <[email protected]> Date: Fri Nov 29 03:52:51 2024 -0600 [patch] create unique certificate for each db2 instance (#1579) commit e04138a Author: David Parker <[email protected]> Date: Tue Nov 26 21:40:39 2024 +0000 [patch] get_default_storage_classes should always set failed=False (#1578) commit 7014f49 Author: Sanjay Prabhakar <[email protected]> Date: Tue Nov 26 16:32:42 2024 +0000 [patch] Add estimates for cpd in readme (#1577) commit 9933bc2 Author: David Parker <[email protected]> Date: Tue Nov 26 13:46:05 2024 +0000 [patch] Use correct variable for mongo extras (#1576) commit bb720a3 Author: David Parker <[email protected]> Date: Tue Nov 26 13:32:30 2024 +0000 [patch] Set cpd_product_version from catalog metadata (#1575) commit ba23e83 Author: Terence Quinn <[email protected]> Date: Mon Nov 25 15:03:03 2024 -0600 [patch] Fix missing catalog_digest (#1574) Co-authored-by: David Parker <[email protected]> commit 0f60c61 Author: Sanjay Prabhakar <[email protected]> Date: Fri Nov 22 17:33:20 2024 +0000 [patch] Add back restore.yml.j2 (#1572) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 739c4d0 Author: David Parker <[email protected]> Date: Fri Nov 22 16:02:24 2024 +0000 [major] Overhaul backup/restore capability (#1557) Co-authored-by: Sanjay Prabhakar <[email protected]> commit d5ef410 Author: David Parker <[email protected]> Date: Fri Nov 22 12:39:48 2024 +0000 [doc] Fix formatting commit 61272c9 Author: Sanjay Prabhakar <[email protected]> Date: Fri Nov 22 12:27:00 2024 +0000 [patch] fix restore for manage role (#1571) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 0a13abd Author: Sanjay Prabhakar <[email protected]> Date: Thu Nov 21 10:40:05 2024 +0000 [patch] Db2 backup/restore: fix copy local to pod script (#1569) Co-authored-by: Sanjay Prabhakar <[email protected]> commit f474509 Author: David Parker <[email protected]> Date: Wed Nov 20 23:43:25 2024 +0000 [major] Move catalog & storage class metadata to python package (#1561) commit df4fe4c Author: Lokesh <[email protected]> Date: Wed Nov 20 08:49:28 2024 -0500 [patch] remove MIRRORLOGPATH folder creation (#1568) commit 5668f33 Author: Lokesh <[email protected]> Date: Wed Nov 20 07:49:43 2024 -0500 [patch] fix conflicting DB config (#1567) commit 5c595c1 Author: Sanjay Prabhakar <[email protected]> Date: Tue Nov 19 17:45:03 2024 +0000 [patch] can skip db2 in br_manage playbook (#1566) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 8c8f993 Author: stonepd <[email protected]> Date: Tue Nov 19 16:39:18 2024 +0000 [patch] update CP4D README, remove outdated fix code (#1565) Co-authored-by: Sanjay Prabhakar <[email protected]> commit 5eb2cd4 Author: Sanjay Prabhakar <[email protected]> Date: Tue Nov 19 14:42:36 2024 +0000 [patch] fix restore for core and fix tar command in restore tasks (#1564) Co-authored-by: Sanjay Prabhakar <[email protected]>
Hi @durera Build fixed - could you please continue review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR needs a description, please add it in the first text box in this PR
port: | ||
targetPort: 9090 | ||
tls: | ||
termination: edge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be either reencrypt or passthrough. The minio service needs to be secure.
Also is this exposing the console? Why is that needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually we don't require route in minio, so will remove it..
- name: api | ||
port: 9000 | ||
targetPort: 9000 | ||
protocol: TCP | ||
- name: console | ||
port: 9090 | ||
targetPort: 9090 | ||
protocol: TCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these secure?
ISSUE: MASAIB-766