Added --watch option to ibexa:encore:compile #1671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendupuis
force-pushed
the
yarn-encore-watch
branch
from
9c2a46e to
84aab74
Compare
adamwojs
reviewed
Aug 11, 2025
adamwojs
approved these changes
Aug 11, 2025
ezrobot
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
alongosz,
ciastektk,
ViniTou,
barw4,
wiewiurdp,
konradoboza and
tbialcz
and removed request for
a team
Steveb-p
reviewed
Aug 12, 2025
| @@ -77,7 +83,8 @@ protected function getFrontendConfigPath(string $configName): string | |||
|
|
|||
| protected function execute(InputInterface $input, OutputInterface $output): int | |||
| { | |||
| $timeout = (float)$input->getOption('timeout'); | |||
| $watch = $input->getOption('watch'); | |||
| $timeout = $watch ? null : (float)$input->getOption('timeout'); | |||
There was a problem hiding this comment.
If someone passes --timeout, but we silently discard it due to --watch, it should raise an error.
There was a problem hiding this comment.
In 84aab74...a220c2d I implemented the error when both options are used at the same time --watch --timeout 123.
To be able to detected if the user passed the --timeout option, I had to remove its default value from definition.
|
Steveb-p
approved these changes
Aug 12, 2025
konradoboza
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow to have
yarn encore dev --watchfeature without changing habitual command.php bin/console ibexa:encore:compile --watchruns until killed, it watches the assets, and rebuilds them on change.About errors:
php bin/console ibexa:encore:compile --watch --timeout 123throws errorWatch mode can't be used with a timeout.php bin/console ibexa:encore:compile --timeoutstill throws errorThe "--timeout" option requires a value.php bin/console ibexa:encore:compile --timeout abcstill throws errorTimeout value has to be an integer.For QA:
Documentation: