Skip to content

Conversation

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR revamps the notifications functionality and introduces new sidebar interactions while updating related configuration and routing. Key changes include:

  • Introducing a new sidebar panel with improved event handling and backdrop management.
  • Revamping notifications modal and list functionality by adding support for actions such as marking notifications as read/unread, bulk operations, and deletion.
  • Updating routing, service configurations, and default settings to support the new notifications features.

Reviewed Changes

Copilot reviewed 27 out of 38 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/bundle/Resources/public/js/scripts/sidebar/side.panel.js New sidebar panel implementation with close triggers and backdrop control.
src/bundle/Resources/public/js/scripts/admin.notifications.modal.js Updates to notifications modal including new actions and improved event management.
src/bundle/Resources/public/js/scripts/admin.notifications.list.js Introduction of notifications list with bulk operations and status management.
src/bundle/Resources/public/js/scripts/admin.notifications.filters.js New filters implementation for notifications.
src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js Improvement in multilevel popup menu initialization with refactored event handling.
src/bundle/Resources/encore/ibexa.js.config.js Updated configuration to include new notifications list entry.
src/bundle/Resources/config/services/controllers.yaml Added new controller service definitions for notifications.
src/bundle/Resources/config/routing.yaml Introduced new routes to support notifications actions.
src/bundle/Resources/config/ezplatform_default_settings.yaml Increased pagination limit for notifications.
Files not reviewed (11)
  • src/bundle/Controller/AllNotificationsController.php: Language not supported
  • src/bundle/Controller/NotificationController.php: Language not supported
  • src/bundle/Form/Data/SearchQueryData.php: Language not supported
  • src/bundle/Form/Type/SearchType.php: Language not supported
  • src/bundle/Resources/public/scss/_header-user-menu.scss: Language not supported
  • src/bundle/Resources/public/scss/_list-filters.scss: Language not supported
  • src/bundle/Resources/public/scss/_notifications-modal.scss: Language not supported
  • src/bundle/Resources/public/scss/_notifications.scss: Language not supported
  • src/bundle/Resources/public/scss/_side-panel.scss: Language not supported
  • src/bundle/Resources/public/scss/ibexa.scss: Language not supported
  • src/bundle/Resources/translations/ibexa_admin_ui.en.xliff: Language not supported
Comments suppressed due to low confidence (1)

src/bundle/Resources/public/js/scripts/admin.multilevel.popup.menu.js:2

  • [nitpick] The function name 'initMutlilevelPopupMenus' appears to contain a typographical error; consider renaming it to 'initMultilevelPopupMenus' for clarity.
const initMutlilevelPopupMenus = (container) => {

@tbialcz tbialcz force-pushed the ibx_9060 branch 2 times, most recently from 106b699 to 46edda7 Compare April 29, 2025 07:41
@albozek albozek force-pushed the ibx_9060 branch 2 times, most recently from 485f3de to d537c29 Compare April 29, 2025 12:58
Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) I found a few issues that need to be fixed.

  1. Clicking the "Mark all as read" button does not update individual notifications — they still display the "Mark as read" button instead of switching to "Mark as unread".
1_mark_as_read.mov
  1. When collapsing the filters, there is a noticeable lag. The behavior should be smooth and seamless. Update: The same situation occurs in the activity log, reported here: https://issues.ibexa.co/browse/IBX-10556
2_lagging.mov
  1. When opening the Notifications modal window or navigating to the full Notifications page, long notification content is not displayed correctly. The text overflows and is not properly truncated or formatted, which causes readability issues.
3_dlugi_request_review_1
3_dlugi_request_review_2.mov
  1. Cannot delete notifications. According to the documentation, I should be able to.
4_delete
  1. In the case when one notification is already read and I select the remaining 9 that are unread, the 'Mark as Read' button is disabled, which it shouldn’t be.
5_mark_as_read_disable
  1. Missing date validation: I can set the 'from' date later than the 'to' date without any errors.
6_brak_walidacji_daty

Example of correct date validation in discounts:

6_przyklad_walidacjidaty
  1. The 'Mark All as Read' button always appears disabled (grayed out) even though it is clickable
7_disable_mark_all_as_read.mov
  1. The 'Mark All as Read' button is clickable across the entire width of the page, even when clicking next to the button rather than on it.
mark_all_as_read_resolution.mov
  1. Not all icons turn gray after being marked as read.
8_brak_odswiezenia_ikony_2.mov
  1. The icon doesn't change dynamically from read to unread; it only updates after refreshing the page.
8_brak_odswiezenia_ikony_read_and_unread.mov
  1. When I click the 'Type' filter and select the 'Content published by Scheduler' option, the filter panel expands and the letter 'r' moves to a new line. It should remain on a single line.
9_rozszerzajace_sie_filtry
  1. In the case of deleted content, the 'Go to Content' option should be disabled (grayed out). (according to design)
10_delete_go_to_content
  1. The 'Send to Trash' notification is not handled correctly. It is also important that for the trash, the hover text should be 'Go to Trash'.
Zrzut ekranu 2025-08-25 o 14 28 25

The message should also include the name of the moved content (according to the design).

Zrzut ekranu 2025-08-25 o 14 27 46
  1. Author images are missing in notifications, e.g., in the content review request. (figma) Decision: is not to do it.

  2. If I have no notifications and my first notification is 'Cancel Scheduling Publication' (Publish Later, and then in drafts discard Publish Later), I get a 500 error.

Nagranie.z.ekranu.2025-08-26.o.11.08.35.mov

I checked this bug on environments 4.6 and 5.0 without the feature, and it does not throw a 500 error.

  1. The 'Request access' notification is not handled correctly.
Zrzut ekranu 2025-08-26 o 13 38 32 Zrzut ekranu 2025-08-26 o 13 40 38

Copy link
Contributor

@KamilSznajdrowicz KamilSznajdrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I set the filter to content unscheduled and in the results I got notifications: sent to trash and content deleted. I shouldn’t have received them.
    Update from @tbialcz : It worked like this until now. The backend needs to be reworked — it will take a lot of time.
Cancel scheduled publication
  1. When toggling a single notification between unread and read, the Status column shifts its position within the table
status_change_pos.mov
  1. After clicking on the "Sent to Trash" notification, I should be redirected to the Trash. Also, the table should be labeled "Go to Trash" according to the design (https://www.figma.com/design/MzQBlhdlUvJEGC6vcDNjWb/2.1--Notifications--Revamp-notifications?node-id=3613-442755&t=PwP5LBCok0FETgoX-0)
send_to_trash
send_to_trash_2.mov
  1. When I have pagination in the filters and switch to another page, the criteria disappear.
Nagranie.z.ekranu.2025-08-28.o.13.14.08.mov

@tbialcz tbialcz requested a review from konradoboza August 28, 2025 10:26
Copy link

@barbaragr
Copy link

barbaragr commented Aug 29, 2025

  1. yarn issues after checking out:
Screenshot 2025-08-29 at 15 07 47
  1. If all notifications are marked as read, right corner button should be inactive like the one in table:
Screenshot 2025-08-29 at 14 53 10
  1. Collaboration notifications need adjustments on the list and side bar:
Screenshot 2025-08-29 at 13 07 16 Screenshot 2025-08-29 at 12 32 12
  1. Collaboration type is missing in filters?
Screenshot 2025-08-29 at 12 34 14
  1. Jumping while opening/closing filters:
    https://github.com/user-attachments/assets/5ed238aa-8f48-4cc9-a7ef-3451ce660e6f

  2. Type in dropdown looks misaligned a little:

misaligned
  1. Dates are not cleared in filters (tested on Firefox, notice that one date is in future):
    https://github.com/user-attachments/assets/3bc9d720-3082-469a-b0ba-5bb2df0178fd

  2. No shade under filter's part of the table:

no_shade Figma: shade in figma
  1. Part of notification is cut when content name is too long:
Screenshot 2025-08-29 at 14 55 51
  1. Go to Content button doesn't work:
nothing happens go to content
  1. Side bar: user should be able to click the notification and then should be redirected to the proper content, notification should be marked as read. If content was deleted, notification should be just marked as read when clicked.

  2. Red information should be displayed in full:

Screenshot 2025-08-29 at 14 57 28
  1. Send to review is broken. View after typing the reviewer:
Screenshot 2025-08-29 at 14 58 36
  1. Marking as read/unread in side bar doesn't work properly - dot colour is not changing.
Screenshot 2025-08-29 at 15 56 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.