Make sure that the digitizer also produces empty output collections #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the encoding as soon as we have the necessary information instead of waiting until the end as that might be jumped over in case parts of the loop are skipped.
We will not enter the loop over the hits in any case if we have 0 hits. But with the continue in place we jump adding the collection to the event.
tmadlener
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
RealisticCaloDigialways creates an output collection, not only if it's non-empty.RealisticCalo{Digi,Reco}to avoid jumping over this in case we exit a loop early.ENDRELEASENOTES
Follow up to #150 where this was missed.