Skip to content

Adding event handler to prevent clicking scroll bars closing suggestion drop down #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding event handler to prevent clicking scroll bars closing suggestion drop down #122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f6e29d
Adding event handler to prevent clicking scroll bars closing the sugg…
nmoore93 Mar 27, 2018
0e9ed9f
Lint error fixes from previous commit
nmoore93 Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/Suggestions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ class Suggestions extends React.Component {
this.props.addTag(item)
}

handleListMouseDown (e) {
// Fix for clicking scroll bars casuing the suggestions drop down to close
e.preventDefault()
}

render () {
if (!this.props.expandable || !this.state.options.length) {
return null
Expand Down Expand Up @@ -72,7 +77,7 @@ class Suggestions extends React.Component {

return (
<div className={this.props.classNames.suggestions}>
<ul role='listbox' id={this.props.listboxId}>{options}</ul>
<ul role='listbox' id={this.props.listboxId} onMouseDown={this.handleListMouseDown.bind(this)}>{options}</ul>
</div>
)
}
Expand Down