re-add docker network create dbs
#9648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to create the dbs network has a storied past: - added hypothesis#7673 - removed abbe35c - added again c2a4fe7 - removed again eb998e1 when cookiecutter was applied to h but didn't include this code. The docker-compose.yml says this network should be created automatically (although there's a misspelling there, fixed here as a bonus), and without this network, trying to follow the dev environment setup if this network had not already been created results in a cryptic error.
|
Force-pushed to fixup with yet another misspelling (I hadn't noticed the "docker crate network" misspelling was both in the compose file and in an include provided to cookiecutter. Not sure how y'all might want to handle the fix in cookiecutter-- is it OK to include this |
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to create the dbs network has a storied past:
The docker-compose.yml says this network should be created automatically (although there's a misspelling there, fixed here as a bonus), and without this network, trying to follow the dev environment setup if this network had not already been created results in a cryptic error.
Of course, the real fix would be to address this in the cookiecutter to prevent this from
being overwritten the next time that might be applied, so I'll make a pull request there, too.