Fix request distribution stats #1071
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `count` was never incremented, and consequently the Incoming Request Distribution and Outgoing Request Distribution panels would no longer show up on the statistics page. Instead of keeping track of the total count independent of the bins, just sum the bins when we need a total count for display purposes. While we're at it, let's get rid of the synchronization too.
Bombe
approved these changes
May 13, 2025
|
You know, sometimes I was wondering where these things went, but I never bothered to actually look for them… 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I broke this 9 years ago, so let's fix it 😄
For those who don't have a memory of these statistics panels, it's these two:
The
countwas never incremented, and consequently the Incoming Request Distribution and Outgoing Request Distribution panels would no longer show up on the statistics page.Instead of keeping track of the total count independent of the bins, just sum the bins when we need a total count for display purposes.
While we're at it, let's get rid of the synchronization too.