Ask in first time wizard whether to donate disk space #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve heard the argument "I don’t want stuff stored on my disk" so often now that if "it’s only in memory" suffices it may just be worth to have a checkbox "donate disk space?" and if toggled off use a RAM store and cache.
That may reduce the lifetime of files but if in exchange many more people use the network, that’s a net win.
Since at least half the nodes are only online 2 hours per day, it’s likely that caches already provide most of the data, so the effect of more RAM only nodes shouldn’t be too bad.
Besides adding the checkbox I fixed a nasty locking issue that prevented switching from salt-hash to ram and then back to salt-hash. This didn’t hit earlier, because switching to salt-hash required a node restart which masked the locking issue.
Also toggles in the first time wizard can now actually be instant.