Skip to content

kafka streams metrics with common app id tag #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kafka streams metrics with common app id tag #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kafka-streams-framework/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ dependencies {
implementation("com.google.guava:guava:31.1-jre")
implementation("org.apache.avro:avro:1.11.1")
implementation("org.apache.kafka:kafka-clients:7.2.1-ccs")
implementation("org.hypertrace.core.serviceframework:platform-metrics:0.1.39")
implementation("org.hypertrace.core.serviceframework:platform-service-framework:0.1.39")
implementation("org.hypertrace.core.serviceframework:platform-metrics:0.1.47")
implementation("org.hypertrace.core.serviceframework:platform-service-framework:0.1.47")
implementation("org.apache.commons:commons-lang3:3.12.0")

testImplementation("org.apache.kafka:kafka-streams-test-utils:7.2.1-ccs")
Expand Down
9 changes: 8 additions & 1 deletion ...s-framework/src/main/java/org/hypertrace/core/kafkastreams/framework/KafkaStreamsApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import static org.apache.kafka.clients.producer.ProducerConfig.COMPRESSION_TYPE_CONFIG;
import static org.apache.kafka.clients.producer.ProducerConfig.LINGER_MS_CONFIG;
import static org.apache.kafka.common.config.TopicConfig.RETENTION_MS_CONFIG;
import static org.apache.kafka.streams.StreamsConfig.APPLICATION_ID_CONFIG;
import static org.apache.kafka.streams.StreamsConfig.DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG;
import static org.apache.kafka.streams.StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG;
import static org.apache.kafka.streams.StreamsConfig.DEFAULT_TIMESTAMP_EXTRACTOR_CLASS_CONFIG;
Expand All @@ -20,6 +21,8 @@
import com.google.common.collect.Streams;
import com.typesafe.config.Config;
import io.confluent.kafka.streams.serdes.avro.SpecificAvroSerde;
import io.micrometer.core.instrument.Tag;
import io.micrometer.core.instrument.Tags;
import io.micrometer.core.instrument.binder.kafka.KafkaStreamsMetrics;
import java.time.Duration;
import java.util.ArrayList;
Expand Down Expand Up @@ -90,7 +93,11 @@ protected void doInit() {
app = new KafkaStreams(topology, streamsConfigProps);

// export kafka streams metrics
metrics = new KafkaStreamsMetrics(app);
metrics =
new KafkaStreamsMetrics(
app,
Tags.of(
Tag.of("kstreams.app", streamsConfigProps.getProperty(APPLICATION_ID_CONFIG))));
metrics.bindTo(PlatformMetricsRegistry.getMeterRegistry());

// useful for resetting local state - during testing or any other scenarios where
Expand Down