Simplify cancellation #1024
Merged
Simplify cancellation #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
cancellation
branch
3 times, most recently
from
8d80a67 to
f1742b2
Compare
ludfjig
added
the
kind/refactor
ludfjig
requested review from
danbugs,
dblnz,
devigned,
jprendes,
marosset,
simongdavies and
syntactically
as code owners
Contributor
simongdavies
left a comment
simongdavies
left a comment
There was a problem hiding this comment.
Some minor commments, on this:
If we want to maintain the old behavior of kill() being effective in the entire MultiUseSandbox::call() scope, we can do that too , just needs moving 1 line of code around (effective here meaning skipping the next VM entry).
I think we should.
jsturtevant
requested changes
Nov 18, 2025
Contributor
jsturtevant
left a comment
jsturtevant
left a comment
There was a problem hiding this comment.
Thanks splitting this out and for the detailed docs!
dblnz
reviewed
Nov 18, 2025
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
Some minor comments from me.
Good work with the docs explaining the cancellation feature and splitting the PR 👍
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
cancellation
branch
from
b9c56ef to
7bf68a9
Compare
jsturtevant
reviewed
Nov 19, 2025
jsturtevant
previously approved these changes
Nov 19, 2025
Contributor
jsturtevant
left a comment
jsturtevant
left a comment
There was a problem hiding this comment.
LGTM, Would like @simongdavies to give one more pass too. There is a bit more clean up we can do but I believe you will take care of that with some of the other PR's in the queue.
Contributor
simongdavies
left a comment
simongdavies
left a comment
There was a problem hiding this comment.
LGTM with minor request for a code comment
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
jsturtevant
reviewed
Nov 19, 2025
jsturtevant
previously approved these changes
Nov 19, 2025
ludfjig
force-pushed
the
cancellation
branch
2 times, most recently
from
ee98dd8 to
a94045c
Compare
…g sandbox Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
cancellation
branch
from
a94045c to
9200b1b
Compare
simongdavies
previously approved these changes
Nov 20, 2025
jsturtevant
reviewed
Nov 20, 2025
jsturtevant
previously approved these changes
Nov 20, 2025
jprendes
reviewed
Nov 20, 2025
ludfjig
dismissed stale reviews from jsturtevant and simongdavies
via
52d7584
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
cancellation
branch
3 times, most recently
from
c457c26 to
8e69643
Compare
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
cancellation
branch
from
8e69643 to
d65d4bb
Compare
simongdavies
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies cancellation logic and unifies logic for all hypervisors, without affecting current behavior. Adds documentation to how everything works