-
Notifications
You must be signed in to change notification settings - Fork 291
fix(json-type): add support for JSON columns in the service dashboard #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Perseus is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
33096cf
to
8d62376
Compare
|
8d62376
to
69ef750
Compare
@wrn14897 @knudtty I've made a function to generalize the creation of coalesced queries based on both of your comments; it feels a little awkward since its building the queries manually and I've tried to keep the queries well-indented to make troubleshooting easier without adding significant amounts of whitespace, but it would be significantly easier if there was a standardized query builder (or I could also write a query builder specifically for this use-case if that sounds better). I've addressed the remaining comments as well. |
… method for filtering json columns (refactor): create generalized method to build coalesced field selection queries (refactor): address minor PR review comments
…consuming ops' panel
59fa00e
to
bfff2fe
Compare
Fixes #1023
useJsonColumns
hook which returns the names of all JSON columns in a specific tablecoalesce(nullIf(...))
queries to access the fields directly due to ClickHouse not supportingNULLIF()
on dynamic columns