-
-
Notifications
You must be signed in to change notification settings - Fork 55
Add auto full screen setting for media file launches only #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: huynhsontung <[email protected]>
Co-authored-by: huynhsontung <[email protected]>
@copilot I’m not a fan of treating audio and video differently. Since it's a launching option why not use the ApplicationView.PreferredLaunchWindowingMode? From the documentation:
|
…o distinction Co-authored-by: United600 <[email protected]>
Good suggestion! I've implemented the PreferredLaunchWindowingMode approach and removed the audio/video distinction as you recommended. Changes made (commit 4791d9c):
The setting now updates |
@copilot After some testing I'm not sure this is what we want. It works, but it also forces the app into fullscreen mode even when opening the app normally. |
…reen Co-authored-by: United600 <[email protected]>
You're absolutely right! I've fixed this issue in commit 1e4aaac. The problem was: Using The fix: Removed the
The setting now only affects immediate fullscreen behavior during file activation via |
This PR adds a new user setting to automatically enter full screen mode when opening media files through file association, providing a seamless viewing experience similar to the default "Movies & TV" app on Windows.
Implementation
The feature uses immediate fullscreen activation during file launches while preserving normal windowed behavior for regular app starts:
Key Features
Auto Full Screen Setting: A new toggle switch in the Player settings section that allows users to enable automatic full screen mode when opening media files.
Targeted Behavior:
Technical Implementation
The feature integrates at the file activation level in
App.xaml.cs
:This approach provides immediate responsiveness for file activations while maintaining standard UWP windowing behavior for normal app launches.
Fixes #663.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.