feat: use AudioGraph to output and process audio #363
+629
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AudioGraph to handle audio output from VLC using audio callbacks. This change allows us to potentially extract audio data for additional post-processing and filtering, or external use cases such as audio visualizations.
As the AudioFrameInputNode has a limited buffer, a circular buffer is used to transport and package audio data from VLC into audio frames. VLC and AudioGraph run on separate threads, interacting with the buffer asynchronously. Due to the complex nature of the producer-consumer model, some audio issues can occur, including delay, click, or hitch.