-
Notifications
You must be signed in to change notification settings - Fork 40
[Dashboard] Join operators address view and the wallet address view #3323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
…o kb/3254-dashboard-changes
…ew fields to the wallet details
…nts, replace scss with mui in the component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanups, esp on breakpoints
LGTM codewise. Minor issues/mismatches I found shared async
<Stack width="100%"> | ||
<TablePagination | ||
// count is unknown but required as props | ||
count={9999} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
count={9999} | |
count={Number.MAX_SAFE_INTEGER} |
then?
Stake Info | ||
</Typography> | ||
<Stack gap={4}> | ||
{amountStaked !== undefined && amountStaked !== null ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{amountStaked !== undefined && amountStaked !== null ? ( | |
{Number.isFinite(amountStaked) && ( |
<TableRow> | ||
<TablePagination | ||
// count is unknown but required as props | ||
count={9999} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe max sage integer here as well?
…ress in the table, add withdrawable tokens
Issue tracking
Closes #3254
Figma: New design
Context behind the change
This PR implements:
Stake Info
section for wallet and operator addressesAlso in this PR I've changed components in favor of using MUI's tools instead of scss, made changes to
theme
, refactored a bunch of small components (reusability, semantic html, simplified styles, hooks, imports, etc)How has this been tested?
Only locally
Release plan
Regular plan
Potential risks; What to monitor; Rollback plan
We still yet to clarify on cumulative graph and whether we want to put SearchBar in the header (most likely, these features will be integrated as a follow-up PR )