Skip to content

[Dashboard] Join operators address view and the wallet address view #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

KirillKirill
Copy link
Contributor

@KirillKirill KirillKirill commented May 8, 2025

Issue tracking

Closes #3254
Figma: New design

Context behind the change

This PR implements:

  • A joined view of the wallet and operator addresses
  • KV Store table for wallet and operator addresses
  • Stake Info section for wallet and operator addresses
  • A specific changes that reflects transaction history with nested tree view
  • Responsive tables (kv store, leaderboard, transactions)

Also in this PR I've changed components in favor of using MUI's tools instead of scss, made changes to theme, refactored a bunch of small components (reusability, semantic html, simplified styles, hooks, imports, etc)

How has this been tested?

Only locally

Release plan

Regular plan

Potential risks; What to monitor; Rollback plan

We still yet to clarify on cumulative graph and whether we want to put SearchBar in the header (most likely, these features will be integrated as a follow-up PR )

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 4:09pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 4:09pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 4:09pm
human-app ⬜️ Skipped (Inspect) May 21, 2025 4:09pm
staking-dashboard ⬜️ Skipped (Inspect) May 21, 2025 4:09pm

@vercel vercel bot temporarily deployed to Preview – human-app May 19, 2025 12:22 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app May 21, 2025 14:18 Inactive
@vercel vercel bot temporarily deployed to Preview – staking-dashboard May 21, 2025 14:18 Inactive
@KirillKirill KirillKirill marked this pull request as ready for review May 21, 2025 14:41
@KirillKirill KirillKirill requested review from dnechay and portuu3 May 21, 2025 14:41
Copy link
Collaborator

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups, esp on breakpoints
LGTM codewise. Minor issues/mismatches I found shared async

<Stack width="100%">
<TablePagination
// count is unknown but required as props
count={9999}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

Suggested change
count={9999}
count={Number.MAX_SAFE_INTEGER}

then?

Stake Info
</Typography>
<Stack gap={4}>
{amountStaked !== undefined && amountStaked !== null ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{amountStaked !== undefined && amountStaked !== null ? (
{Number.isFinite(amountStaked) && (

<TableRow>
<TablePagination
// count is unknown but required as props
count={9999}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe max sage integer here as well?

@vercel vercel bot temporarily deployed to Preview – human-app May 21, 2025 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – staking-dashboard May 21, 2025 16:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard] Join operators address view and the wallet address view
2 participants