Skip to content

Conversation

@ishitab02
Copy link
Contributor

Summary

What does this PR do?

This PR consolidates slow test cases from the tests/slow/ directory into their respective main test files to improve test organization and maintainability.

Fixes #4401

Changes

  • Moved test cases from tests/slow/test_dpo_slow.py to tests/test_dpo_trainer.py
  • Moved test cases from tests/slow/test_grpo_slow.py to tests/test_grpo_trainer.py
  • Moved test cases from tests/slow/test_sft_slow.py to tests/test_sft_trainer.py
  • Added missing imports (gc, BitsAndBytesConfig) that were causing linting errors
  • Removed obsolete tests/slow/ test files

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

ishitab02 and others added 4 commits October 31, 2025 01:51
Moved slow test cases from tests/slow/ directory into their respective
main test files and added missing imports (gc, BitsAndBytesConfig).
Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @albertvillanova is it ok for you as well?
In my opinion, most of these slow test could be removed, and are mostly redundant with non-slow test, but this is out of the scope of this PR.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I just fixed the conflicts with main.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec qgallouedec merged commit 3d718df into huggingface:main Oct 31, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move everything in test/slow to their respective trainer test files

4 participants