Skip to content

Conversation

@kashif
Copy link
Collaborator

@kashif kashif commented Oct 30, 2025

What does this PR do?

The tiny Qwen2.5-VL test model had mrope_section: [2] (only 1 element), but the Liger Kernel expects at least 2 elements:

  • mrope_section[0]: temporal dimension split
  • mrope_section[1]: height dimension split

Fixes CI failure in #4364

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec
Copy link
Member

CI fix by increasing the LR for two tests

@qgallouedec qgallouedec merged commit a8f70b0 into main Oct 30, 2025
11 of 12 checks passed
@qgallouedec qgallouedec deleted the mrope-tiny branch October 30, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants