Add Qwen3Model
#627
Open
Add Qwen3Model
#627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2669a5c.
|
What else needs to be completed for this PR? |
kozistr
reviewed
Jun 9, 2025
Comment on lines
+217
to
+221
| let gate_states = match self.act { | ||
| HiddenAct::Gelu => gate_states.gelu(), | ||
| HiddenAct::Relu => gate_states.relu(), | ||
| HiddenAct::Swiglu => gate_states.silu(), | ||
| }?; |
There was a problem hiding this comment.
nit) I've recently added forward method to HiddenAct enum here!
how about using this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for the recently released Qwen3 Embedding models on the Hugging Face Hub.
Note that re-ranking support won't be introduced in this PR but on a follow up PR, as well as MPS support eventually too.
Closes #626
Before submitting
Who can review?
@Narsil