-
Notifications
You must be signed in to change notification settings - Fork 144
lets callers inject a prebuilt Tokenizer in the LanguageModel #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kashif! 🙌
I have some questions about the potentially confusing use of configuration and tokenizer, could we maybe make behaviour more explicit, or perhaps defer configuration to a later PR if it's not essential?
Examples/transformers-cli/Sources/transformers-cli/Transformers.swift
Outdated
Show resolved
Hide resolved
|
thanks! will look shortly and fix |
…s.swift Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!! 🙌
Co-authored-by: Pedro Cuenca <[email protected]>
fixes #238