Skip to content

Conversation

@kashif
Copy link
Contributor

@kashif kashif commented Oct 4, 2025

fixes #238

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kashif! 🙌

I have some questions about the potentially confusing use of configuration and tokenizer, could we maybe make behaviour more explicit, or perhaps defer configuration to a later PR if it's not essential?

@kashif
Copy link
Contributor Author

kashif commented Oct 8, 2025

thanks! will look shortly and fix

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! 🙌

@pcuenca pcuenca merged commit 9dad29e into huggingface:main Oct 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing Tokenizer to LanguageModel

2 participants