feat: Update swift-argument-parser to version 1.5.0 or higher #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update swift-argument-parser to version 1.5.0 or higher
matiasvillaverde
added a commit
to matiasvillaverde/swift-sentencepiece
that referenced
this pull request
Feb 18, 2025
Update to be compatible with SwiftTransformers until this PR is merged huggingface/swift-transformers#179
|
Hi @matiasvillaverde. Thanks for opening this PR. Your change was indeed a better way to pull in `swift-argument-parser. I'm happy to report that we've gone ahead and removed that dependency entirely with #235 (motivated in part because of the challenges you highlighted in this PR). So we shouldn't have this problem going forward 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update swift-argument-parser to version 1.5.0 or higher
Small PR to update the argument parser. This makes it compatible with other dependencies like swift-embeddings, which require version 1.5.0 or higher.