Skip to content

Raise ValueError if only one of height or width is provided #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Raise ValueError if only one of height or width is provided #119

merged 1 commit into from
Jul 22, 2025

Conversation

alvarobartt
Copy link
Member

Description

This PR raises a ValueError if only one of height or width is provided, as either both are provided or both are None (not provided). Note that it's also handled when those values are provided via target_size.

cc @ErikKaum @beurkinger

@alvarobartt alvarobartt requested a review from ErikKaum July 21, 2025 12:53
ErikKaum
ErikKaum approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@ErikKaum ErikKaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good, thank you 👍

@alvarobartt alvarobartt merged commit 2d4f7f1 into main Jul 22, 2025
6 checks passed
@alvarobartt alvarobartt deleted the fix-text-to-image-hw branch July 22, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikKaum ErikKaum ErikKaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarobartt @ErikKaum