Skip to content

Implements OAuth Dance #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implements OAuth Dance #5

wants to merge 1 commit into from

Conversation

drusellers
Copy link
Member

@drusellers drusellers commented Aug 18, 2016 •
edited
Loading

Closes #1 when done.

Build out initiating route /auth

Build out handshake route /auth/handshake

  • takes data and makes an HTTP request per spec to get the access_token
  • stores access token in session at github_access_token

With those two steps auth with GitHub should be done.

NOTE: We are not storing the token

ISSUE: accessing form data is not working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drusellers