Skip to content

Highpass before demod #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 23, 2025
Merged

Highpass before demod #884

merged 17 commits into from
Oct 23, 2025

Conversation

@keskitalo
Copy link
Member

This PR extends TOAST capabilities to handle SO data.

  • Demodulate now isolates the 2f and 4f signals with a user-configured bandpass filter
  • there is a new operator, SimpleStatCut, that measures the median-filtered skew and kurtosis and uses them to reject outlier detectors
  • CalibrateDetectors can retrieve the gains from the focalplane database
  • 'SimpleDeglitch' works on demodulated data and will flag all affected streams

@keskitalo
Highpass-filter the signal before demodulation
8cf6ba0
@keskitalo
Experiment with bandpass filtering
66b12e6
@keskitalo
Use passband rather than highpass filter
56d42f0
@keskitalo
Flag pathological detectors
89b3ae6
@keskitalo
Better help strings
22bc8a6
@keskitalo
Add operator for rms/skew/kurtosis-based detector cuts
c46b674
@keskitalo
Remove debug statements
6ba58f9
@keskitalo
Remove debug statement, make error message more informative
2f50311
@keskitalo
When deglitching demodulated data, apply flags to all coupled streams
653f381
@keskitalo
Fix error in flag mask application
8fe232a
@keskitalo
Fix two corner cases in time constant deconvolution
1849650
@keskitalo
Add a helpful warning message
b6fde5a
@keskitalo
Add accessor for the detector properties list
c885029
@keskitalo
Calibrate now looks for gains in the focalplane database when a dicti…
3085548 
…onary is not found in the Observation. It is an error if no gains are found
@keskitalo
Demodulation allows adjusting the passband
a8458f0
@keskitalo
better trait names
6bf3929
@keskitalo keskitalo marked this pull request as ready for review October 23, 2025 18:44
@keskitalo keskitalo requested a review from tskisner October 23, 2025 18:44
tskisner
tskisner approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these great improvements! One small comment about stale lines of code.

@keskitalo keskitalo merged commit 77aa5f3 into toast3 Oct 23, 2025
7 checks passed
@keskitalo keskitalo deleted the highpass_before_demod branch October 23, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tskisner tskisner tskisner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keskitalo @tskisner