[Hardware Wallet Support Milestone 2] ECDSA Custom Signature Pallet UI implementation #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[note]: this pull request was merged to clean the bloating commits done to this branch * boilerplate work for making a new page * added ethereum provider hooks (wip) * added assert polyfil and eth signature recovery * reset error message * improved address change event handler * added custom signature call (WIP) * changed ecdsa address view component * changed call encoding * added dynamic chain address format * fixed account switch handler * compress recovered public key * added transaction confirmation modal * boilerplate work for making a new page * added ethereum provider hooks (wip) * added assert polyfil and eth signature recovery * reset error message * improved address change event handler * added custom signature call (WIP) * changed ecdsa address view component * changed call encoding * added dynamic chain address format * fixed account switch handler * compress recovered public key * added transaction confirmation modal * updated react component package version * fixed dependencies list
hoonsubin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Summary
This pull request adds the Custom Signature page under the Account tab.
The Custom Signature page allows the user to submit a transaction that was signed with an Ethereum private key and use it as a native ECDSA account in Substrate. Plus, you are able to use MetaMask for signature requests, which allows users to use their Ethereum address inside Ledger and Trezor to create a transaction.
Preview
ecdsa-sig-final.mp4
Notable Changes
assertbrowser polyfill that is used by theethereumjs-utilpackagecustom-signaturepage that will be available for chains that implement thecustom-signaturespallet (https://github.com/PlasmNetwork/Plasm/tree/dusty/frame/custom-signatures) asEthCall(https://github.com/PlasmNetwork/Plasm/blob/feature/vectorized-custom-signatures/bin/node/runtime/src/lib.rs#L649)Usage
Currently, this page is made with MetaMask in mind. Most browser-injected ethereum wallets that use the
window.ethereumobject and accept thepersonal_signmethod should be compatible, but please understand that there may be unexpected errors.You can learn more about the usage from this doc: https://docs.plasmnet.io/workshop-and-tutorial/metamask-signatures