Skip to content

fixed off-by-one error on line 366 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed off-by-one error on line 366 #146

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2020

This works just fine on my machine.

willhaslett
willhaslett reviewed Oct 23, 2020
View reviewed changes
Copy link

@willhaslett willhaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I'd leave out the comment. The history for this line of code is in the commit history / blame.

@ghost
Copy link
Author

ghost commented Oct 23, 2020

I removed the comment.

@davidem davidem mentioned this pull request Sep 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@willhaslett