fix: update chainhook predicate start_block upon re-registration #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://token-metadata-pgqyxgdca-hirosystems.vercel.app 🚀 |
haneytron
reviewed
Jun 4, 2025
haneytron
reviewed
Jun 4, 2025
haneytron
approved these changes
Jun 4, 2025
janniks
approved these changes
Jun 4, 2025
janniks
reviewed
Jun 4, 2025
hirosystems-release-bot bot
added a commit
that referenced
this pull request
Jun 4, 2025
## [1.2.1-beta.1](v1.2.0...v1.2.1-beta.1) (2025-06-04) ### Bug Fixes * update chainhook predicate start_block upon re-registration ([#308](#308)) ([929f08e](929f08e))
|
🎉 This PR is included in version 1.2.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a chainhook predicate goes obsolete, update its starting block height on re-registration.
There is a bug on chainhook which sometimes marks active predicates as inactive, forcing the Metadata API to re-register so it receives blocks again. However, since we weren't updating the re-registration starting block height, we ended up in an infinite loop that made us receive blocks from the last block height seen on boot. This caused the API to fall significantly behind chain tip.