Support additional types in putFile #693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Bump to v19.2.5. Bump to v19.2.4 and include script-dist-file.md
… typedoc and typescript minor versions
…his is intended for use in third-party wallets or in DApps that register names." Also, this exposes AuthScope. Signed-off-by: Mary Anthony <[email protected]>
Signed-off-by: Mary Anthony <[email protected]>
* develop: Remove extra console log from tests. Update bitcoinjs-lib -- includes improvements to the native secp256k1 depedencies Throw error on user session overwrite. Update to typed `jsontokens` lib, fix all typing errors # Conflicts: # package-lock.json
* network-reveal: Fixing line length Exposing the Blockstack network. Adding the caveat to the getName* "This is intended for use in third-party wallets or in DApps that register names." Also, this exposes AuthScope. Expose the `BlockstackNetwork` class and the default instance, update typedoc and typescript minor versions Remove jsdoc types from network.ts # Conflicts: # mdincludes/script-dist-file.md
Codecov Report
@@ Coverage Diff @@
## develop #693 +/- ##
===========================================
+ Coverage 75.34% 75.49% +0.14%
===========================================
Files 57 57
Lines 2868 2897 +29
Branches 220 221 +1
===========================================
+ Hits 2161 2187 +26
- Misses 679 682 +3
Partials 28 28
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #693 +/- ##
===========================================
+ Coverage 68.98% 69.14% +0.15%
===========================================
Files 57 57
Lines 3321 3354 +33
Branches 596 601 +5
===========================================
+ Hits 2291 2319 +28
- Misses 745 748 +3
- Partials 285 287 +2
Continue to review full report at Codecov.
|
|
@zone117x needs to add some testing criteria for @timstackblock |
* develop: Bump version to v19.3.0-beta.1 PR template formatting changes Use case and acceptance criteria in pull request template. More pull request template changes. More pull request template changes. Pull request template changes. Add checklist to pull request template More pull request template updates. More pull request template updates. Update pull request template Add a pull request template.
This was referenced Aug 25, 2019
|
@timstackblock @yknl Created a draft PR against the app-generator with example usages -- see the updated PR acceptance criteria for links |
* develop: Update worldlist filter with single regex Exclude unused bip39 wordlists from dist bundle (saves around 240KB uncompressed)
|
@zone117x The app-generator PR was helpful looks good so far I should be finish with this shortly |
|
This is complete and test passed |
timstackblock
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689
Adds support for
File,Blob, andTypedArrays to theputFilefunction.When encryption is not enabled, the stream types are sent directly through to the
fetchPOST body and streamed from disk -> network when appropriate.However, this PR does not improve the encryption related issues. When encryption is enabled, the stream types are buffered into memory, then encrypted and POSTed.
Support for the
ReadableStreamtype is blocked by web browsers having yet to implement whatwg/fetch#425.jsdom is used in the unit tests to polyfill the DOM File APIs
Acceptance criteria
putFileandgetFile.putFilewithFileobjects -- opened a PR with several example usages of this here Storage API usage example stacks-archive/blockstack-app-generator#65 as well as a live demo here https://zone117x.github.io/blockstack-file-api-demo/dist/index.html