Fix nullref on visitors with no acceptors #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a visitor has no acceptors, a nullref with crash the generator, failing to generate source across the entire project.
This PR fixes the issue by simply not generating any source for the visitors that have no acceptors. As I believe, it does not hurt to just ignore the visitors and keep them there, without any acceptor implementations, unless explicitly defined as the model suggests.
I tested this by adding some tests and basically building the test project to contain unit tests ready for execution, using NUnit. It has been opened as a separate PR: #2.