fix(kotlin) number literals #4307
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flofriday
force-pushed
the
fix-kotlin-number-literals
branch
2 times, most recently
from
cd48c9c to
24fcd0e
Compare
Previously kotlin resused the java number parsing but there are significant differnces in how the two languages express numbers causing false-negatives and false-positives.
flofriday
force-pushed
the
fix-kotlin-number-literals
branch
from
24fcd0e to
d5aa057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the parser for Kotlin reused the Java number parsing but there are significant differences in how the two languages express numbers causing false-negatives and false-positives.
Resolves #4305
Changes
Implemented a custom parser for Kotlin number literals since they are different enough from Java literals to justify their own parser.
My hunch is that the orginal implementor misinterpreted the release notes from Kotlin 1.1 which they referenced since this only applies to how seperators in Kotlin follow the same rules as Java 8 and not how all the number parsing is identical to Java 8.
Moreover, in the 9 years since Kotlin 1.1 the language has changed a lot and for example back then unsigned number literals surely weren't a thing.
Checklist
CHANGES.md