Skip to content

Fixed topic redirects for topics with ? in name #12122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed topic redirects for topics with ? in name #12122

wants to merge 3 commits into from
+23 −8

Conversation

mzparacha
Copy link
Contributor

Link to Issue

Closes: #12047

Description of Changes

  1. Fixed topic redirects for topics with ? in name
  2. Updated all instances of topic name validations to disallow ? char

Test Plan

  1. Ensure you can no longer add ? in topic name by create/update flows
  2. Verify that clicking on an existing topic with ? in name redirects to discussion page for that topic correctly.

Deployment Plan

N/A

Other Considerations

N/A

@mzparacha mzparacha self-assigned this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masvelio masvelio masvelio approved these changes

@rbennettcw rbennettcw rbennettcw approved these changes

@burtonator burtonator Awaiting requested review from burtonator burtonator is a code owner

@timolegros timolegros Awaiting requested review from timolegros timolegros is a code owner

@Rotorsoft Rotorsoft Awaiting requested review from Rotorsoft Rotorsoft is a code owner

@kurtassad kurtassad Awaiting requested review from kurtassad kurtassad is a code owner

Assignees

@mzparacha mzparacha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a topic has a "?" The topic gets redirects to /discussions
3 participants
@mzparacha @masvelio @rbennettcw