Skip to content

Judged contest fixes #12056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 14, 2025
Merged

Judged contest fixes #12056

merged 20 commits into from
May 14, 2025

Conversation

rbennettcw
Copy link
Contributor

@rbennettcw rbennettcw commented May 2, 2025 •
edited
Loading

Link to Issue

Closes: #11829
Closes: #11830
Closes: #11584
Closes: #11582
Closes: #12143

Description of Changes

  • Adds FIXME widget to TODO page.

"How We Fixed It"

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@rbennettcw
Copy link
Contributor Author

@masvelio The platform side is all wired up AFAICT, however it looks like the UI doesn't ever use the nominateJudge helper which adds judges to a contest. Once that's wired up, then platform will detect the onchain event and update contestManager.namespace_judges and properly block/allow votes on a judged contest.

@masvelio
Copy link
Contributor

masvelio commented May 7, 2025

@masvelio The platform side is all wired up AFAICT, however it looks like the UI doesn't ever use the nominateJudge helper which adds judges to a contest. Once that's wired up, then platform will detect the onchain event and update contestManager.namespace_judges and properly block/allow votes on a judged contest.

This part has not been started because of priorities shift. There is a ticket that should cover it but it needs prioritisation @dillchen

@rbennettcw rbennettcw marked this pull request as ready for review May 8, 2025 17:14
Rotorsoft
Rotorsoft approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

@rbennettcw rbennettcw merged commit 712f0d4 into master May 14, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masvelio masvelio masvelio approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@kurtassad kurtassad kurtassad approved these changes

@mzparacha mzparacha Awaiting requested review from mzparacha mzparacha is a code owner

@burtonator burtonator Awaiting requested review from burtonator burtonator is a code owner

@timolegros timolegros Awaiting requested review from timolegros timolegros is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rbennettcw @masvelio @Rotorsoft @kurtassad