Handle whitespace more generically #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue of non-breaking spaces being discarded, resulting in words being joined together. `\s` and `\S` only match on space (character 32). HTML often uses non-breaking spaces (character 160). A more general approach is to use `[[:space:]]` instead. According to the `Regexp` documentation, `[[:space:]]` matches "Whitespace character ([:blank:], newline, carriage return, etc.)" Fixes hgmnz#68
sonjapeterson
added a commit
to BookBub/truncate_html
that referenced
this pull request
Nov 30, 2016
This is based on a currently unmerged PR to the main repo: hgmnz#69 It fixes an issue where truncate_html would remove non breaking spaces, resulting in words being joined together incorrectly. Now they are treated like other whitespaces.
|
Bump! I need this, it is such a useless gem, but I am having issues with characters being stripped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of non-breaking spaces being discarded, resulting in words being joined together.
\sand\Sonly match on space (character 32). HTML often uses non-breaking spaces (character 160). A more general approach is to use[[:space:]]instead. According to theRegexpdocumentation,[[:space:]]matches "Whitespace character ([:blank:], newline, carriage return, etc.)"Fixes #68