Skip to content

Conversation

volesen
Copy link
Contributor

@volesen volesen commented Sep 3, 2025

Closes #2230
Closes #2521
Related #2539

Alternatively, I think the cleanest approach would be to handle Header instances separately, as they always contain string as values.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: 391ced3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 3, 2025
Copy link

vercel bot commented Sep 3, 2025

@volesen is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added bug 🔥 Something isn't working client Client package related labels Sep 3, 2025
Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2585
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2585
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2585
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2585

commit: 391ced3

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.19%. Comparing base (ec26321) to head (391ced3).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...s/src/plugins/@hey-api/client-nuxt/bundle/utils.ts 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
+ Coverage   24.16%   24.19%   +0.03%     
==========================================
  Files         363      363              
  Lines       36629    36654      +25     
  Branches     1644     1650       +6     
==========================================
+ Hits         8850     8869      +19     
- Misses      27766    27772       +6     
  Partials       13       13              
Flag Coverage Δ
unittests 24.19% <79.31%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @volesen can you add the same logic to the other clients so they maintain feature parity? And what's the alternative approach you mention?

@volesen volesen force-pushed the volesen/node-compatible-mergeHeaders branch from 3f455a6 to b27f069 Compare September 7, 2025 10:22
@volesen
Copy link
Contributor Author

volesen commented Sep 7, 2025

@mrlubos, I just updated all instances using Header.entries - the remaining client implementations are using custom header classes

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 7, 2025
@mrlubos mrlubos merged commit 67e066f into hey-api:main Sep 7, 2025
12 of 13 checks passed
@hey-api hey-api bot mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🔥 Something isn't working client Client package related lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error from generated mergeHeaders function Generated client uses header.entries() requiring lib: dom.iterable in tsconfig
2 participants