Add sound- operation extraction #1288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quite odd that this is worse, I had high hopes for this. I looked into some diffs and honestly I have no idea what's going on, besides the basic idea that this PR creates more rewritable expressions so the node limit is exhausted faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new kind of operator within the egraph:
(safe-F x y ... default). The real semantics is that it returns(F x y ...), unless that would crash, in which case it instead returnsdefault. This should be more permissive for rewriting that the currentunsound-Fapproach and should ultimately allow us to solve, say, the quadratic examples again.https://chatgpt.com/codex/tasks/task_e_68521fa019ec833185e3129d9eeb730e