Wait until transactions are confirmed, not merely sent. #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ke6jjj
force-pushed
the
jsc/confirm-txns
branch
from
f86f823 to
7ddce36
Compare
Use `send_and_confirm_transaction` instead of `send_transaction_with_config` as the former only returns once the transaction has been confirmed (via the "finalized" strategy) or has timed out. The latter method only sends the transaction in the _hopes_ that it will be confirmed, which, during periods of high congestion, isn't a secure strategy.
ke6jjj
force-pushed
the
jsc/confirm-txns
branch
from
7ddce36 to
a1d9831
Compare
madninja
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
send_and_confirm_transactioninstead ofsend_transaction_with_configas the former only returns once the transaction has been confirmed (via the "finalized" strategy) or has timed out. The latter method only sends the transaction in the hopes that it will be confirmed, which, during periods of high congestion, isn't a secure strategy.