PROPOSAL: Follow the DOM spec instead of HTML 5 spec for Attributes. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API aims to conform to the HTML 5 specification, and does a perfect job of that. However, the [toVirtualDom](https://package.elm-lang.org/packages/hecrj/html-parser/latest/Html-Parser-Util#toVirtualDom) function will break because `setAttribute` and HTML 5 follow different specs. This PR proposes this change to avoid runtime exceptions in the Elm runtime. https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute Ideally, `elm/virtual-dom` would skip adding the attribute or filter the invalid characters, but that's a bigger ask. Feel free to reject this PR, but I did want to float the idea.
|
I think it makes more sense to have this as a different "sanitization" step after parsing; rather than adapting the parsing logic itself. Maybe a |
|
Agreed, I like that idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API aims to conform to the HTML 5 specification, and does a perfect job of that.
However, the toVirtualDom function will break because
setAttributeand HTML 5 follow different specs.This PR proposes this change to avoid runtime exceptions in the Elm runtime. https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute
Ideally,
elm/virtual-domwould skip adding the attribute or filter the invalid characters, but that's a bigger ask.Feel free to reject this PR, but I did want to float the idea.